Skip to content

Conversation

@JasonXuDeveloper
Copy link
Owner

Summary

Multiple fixes for the release workflow:

1. Fix tag format

  • Changed from v1.0.5 to 1.0.5 (existing tags don't have v prefix)
  • This was causing the changelog to include ALL commits instead of just since last release

2. Fix bot email for avatar

  • Changed to GitHub's bot email format: {APP_ID}+jengine-release-bot[bot]@users.noreply.github.com
  • This should make the app avatar show on commits made by the bot

3. Update README with full changelog

  • Previously only updated the version number in header
  • Now replaces the entire "Latest Features" section with actual changelog content
  • Includes both features and bug fixes from the release

Changes

- BASE_TAG="v$CURRENT_CORE"
+ BASE_TAG="$CURRENT_CORE"

- git config user.email "release-bot[bot]@jengine.xgamedev.net"
+ git config user.email "${APP_ID}+jengine-release-bot[bot]@users.noreply.github.com"

# README now gets full feature list, not just version number

Test plan

  • Merge and run release workflow
  • Verify changelog only includes commits since last release (not all commits)
  • Check that bot avatar shows on the release commit
  • Confirm README.md and README_zh_cn.md have updated feature lists

🤖 Generated with Claude Code

@JasonXuDeveloper JasonXuDeveloper force-pushed the fix/release-workflow-improvements branch from d512b25 to 1b3c0fd Compare January 25, 2026 09:00
@github-actions
Copy link

github-actions bot commented Jan 25, 2026

Unity Test Results

EditMode: All tests passed
PlayMode: All tests passed

Unity Version: 2022.3.55f1
Project Path: UnityProject

✅ All tests passed! The PR is ready for review.

View workflow run

Click here to view the full workflow run

@JasonXuDeveloper JasonXuDeveloper force-pushed the fix/release-workflow-improvements branch from 1b3c0fd to 11d4aee Compare January 25, 2026 09:01
1. Fix tag format - use existing format without 'v' prefix (1.0.5 not v1.0.5)
2. Fix bot email to use GitHub's format so app avatar shows on commits
3. Update README sections with full changelog content, not just version number

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
@JasonXuDeveloper JasonXuDeveloper force-pushed the fix/release-workflow-improvements branch from 11d4aee to 8cb4f3e Compare January 25, 2026 09:01
@JasonXuDeveloper JasonXuDeveloper enabled auto-merge (squash) January 25, 2026 09:02
@claude
Copy link

claude bot commented Jan 25, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@claude
Copy link

claude bot commented Jan 25, 2026

Code Review

Found 2 issues related to sed command usage in the workflow.


Issue 1: README.md sed command (line 334)

The sed c command with literal newlines in NEW_SECTION will not work as intended. GNU sed interprets the first literal newline as the end of the replacement text, meaning only the first line will be used.

Location:

# Replace the entire Latest Features section in README.md
# Match from "## 🎉 Latest Features" to just before "## 📊 Project Statistics"
sed -i '/^## 🎉 Latest Features/,/^\[📋 View Complete Changelog\]/c\'"$NEW_SECTION" README.md
echo "✅ Updated README.md with new features"

The NEW_SECTION variable is constructed using bash newline syntax which creates actual newline characters. For multi-line replacements with sed c command, each line (except the last) must end with a backslash for line continuation.

Suggested fix: Use a temp file approach with the r command instead of c command.


Issue 2: README_zh_cn.md sed command (line 362)

Same issue as above but for the Chinese README file.

Location:

NEW_SECTION="## 🎉 最新功能 (v$VERSION)"$'\n'$'\n'"$FEATURES"$'\n'$'\n'"[📋 查看完整更新日志](CHANGE.md)"
# Replace the entire Latest Features section in README_zh_cn.md
sed -i '/^## 🎉 最新功能/,/^\[📋 查看完整更新日志\]/c\'"$NEW_SECTION" README_zh_cn.md
echo "✅ Updated README_zh_cn.md with new features"

Suggested fix: Same temp file approach as Issue 1.

@JasonXuDeveloper JasonXuDeveloper merged commit 0feaa40 into master Jan 25, 2026
11 checks passed
@JasonXuDeveloper JasonXuDeveloper deleted the fix/release-workflow-improvements branch January 25, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants