Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code
#908
+164
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[WORKFLOW_DESERIALIZE]` computed property usage in bundled code
🦋 Changeset detectedLatest commit: 26067bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🪟 Windows (1 failed)nextjs-turbopack (1 failed):
🌍 Community Worlds (169 failed)mongodb (42 failed):
redis (42 failed):
starter (43 failed):
turso (42 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
❌ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
This was referenced Jan 30, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the detection of serializable classes in bundled third-party packages by adding support for recognizing computed property usage of WORKFLOW_SERIALIZE and WORKFLOW_DESERIALIZE symbols.
Changes:
- Added regex pattern to detect computed property usage of workflow serialization symbols in bundled code
- Updated serialization methods to use
.call()for properthiscontext binding - Included serializable files in bundle entries to ensure proper discovery
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/builders/src/transform-utils.ts | Added workflowSerdeComputedPropertyPattern regex to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage, integrated it into detection logic and turbopack content pattern |
| packages/builders/src/transform-utils.test.ts | Added comprehensive test coverage for the new computed property pattern, including bundled code scenarios, edge cases, and integration tests |
| packages/builders/src/base-builder.ts | Added serdeFiles to entriesToBundle array and clarified comments about package export requirements |
| packages/core/src/serialization.ts | Updated serialize and deserialize method invocations to use .call() for proper this context binding |
| .changeset/three-apples-draw.md | Added changeset documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix detection of serializable classes in bundled code by recognizing computed property usage of
[WORKFLOW_SERIALIZE]and[WORKFLOW_DESERIALIZE].What changed?
workflowSerdeComputedPropertyPatternto detect computed property usage ofWORKFLOW_SERIALIZEandWORKFLOW_DESERIALIZEsymbolsdetectWorkflowPatternsto identify serializable classes based on this patternturbopackContentPatternto include the new pattern for content matchingcall()to ensure the class constructor is thethisvalueHow to test?
WORKFLOW_SERIALIZEandWORKFLOW_DESERIALIZEas computed propertiesthiscontextWhy make this change?
When third-party packages are bundled, the standard import pattern detection for
@workflow/serdefails because imports are often from internal chunk files rather than directly from the package. This change ensures that serializable classes are properly detected even in bundled code by looking for the actual computed property usage pattern, improving compatibility with bundled dependencies.