-
Notifications
You must be signed in to change notification settings - Fork 180
Use proper pluarlization in the builder log line #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper pluarlization in the builder log line #898
Conversation
🦋 Changeset detectedLatest commit: b6a2a05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (161 failed)mongodb (40 failed):
redis (40 failed):
starter (41 failed):
turso (40 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the grammatical correctness of the builder's log output by adding proper pluralization for counts of steps, workflows, and classes in the manifest creation log message.
Changes:
- Imported the
pluralizeutility function from@workflow/utils - Updated the log message to use proper singular/plural forms based on actual counts instead of hardcoded "(s)" and "(es)" suffixes
- Added
@workflow/utilsas a dependency to the builders package
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .changeset/fancy-news-throw.md | Documents the patch version change for this improvement |
| packages/builders/package.json | Adds @workflow/utils dependency to access the pluralize utility |
| pnpm-lock.yaml | Updates lock file to reflect the new dependency |
| packages/builders/src/base-builder.ts | Updates the manifest creation log message to use proper pluralization |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Peter Wielander <mittgfu@gmail.com>

Improved log message pluralization in the builder output.
What changed?
@workflow/utilsas a dependency to the builders package to utilize thepluralizeutility functionHow to test?
Run a build with different numbers of steps, workflows, and classes to verify that the log message uses the correct singular or plural forms:
Why make this change?
This change improves the readability and grammatical correctness of the builder's log output by ensuring proper singular/plural forms are used based on the actual count of items. This makes the logs more professional and easier to read.