Skip to content

fix: Human in the Loop - Canvas labels don't work in Condition/Response blocks #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wingding12 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Human in the Loop - Canvas labels don't work in Condition/Response blocks #2974

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6db8404
fix: enable block label references in condition expressions
wingding12 Jan 24, 2026
c67a9b3
fix: add warning log for duplicate block variable names
wingding12 Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions apps/sim/app/api/function/execute/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,51 @@ function resolveEnvironmentVariables(
return resolvedCode
}

/**
* JavaScript reserved words and built-in identifiers that should not be overwritten.
*/
const RESERVED_IDENTIFIERS = new Set([
// JavaScript reserved words
'break', 'case', 'catch', 'continue', 'debugger', 'default', 'delete', 'do',
'else', 'finally', 'for', 'function', 'if', 'in', 'instanceof', 'new',
'return', 'switch', 'this', 'throw', 'try', 'typeof', 'var', 'void', 'while',
'with', 'class', 'const', 'enum', 'export', 'extends', 'import', 'super',
'implements', 'interface', 'let', 'package', 'private', 'protected', 'public',
'static', 'yield', 'await', 'async', 'null', 'true', 'false', 'undefined',
// Built-in objects commonly used
'console', 'Math', 'JSON', 'Date', 'Array', 'Object', 'String', 'Number',
'Boolean', 'Error', 'Promise', 'Map', 'Set', 'Symbol', 'Proxy', 'Reflect',
// Execution context variables
'params', 'environmentVariables', 'context', 'fetch',
])

/**
* Injects block outputs as JavaScript variables by their normalized names.
* This allows users to reference blocks directly by label (e.g., `humanApproval.approved`)
* without requiring angle bracket syntax.
*/
function injectBlockVariables(
blockData: Record<string, unknown>,
blockNameMapping: Record<string, string>,
contextVariables: Record<string, unknown>
): void {
for (const [normalizedName, blockId] of Object.entries(blockNameMapping)) {
// Skip reserved identifiers to avoid conflicts
if (RESERVED_IDENTIFIERS.has(normalizedName)) {
continue
}
// Skip if already defined by another resolution step
if (normalizedName in contextVariables) {
logger.warn(`Block variable '${normalizedName}' already exists in context, skipping injection for blockId: ${blockId}`)
continue
}
const blockOutput = blockData[blockId]
if (blockOutput !== undefined) {
contextVariables[normalizedName] = blockOutput
}
}
}

function resolveTagVariables(
code: string,
blockData: Record<string, unknown>,
Expand All @@ -479,6 +524,10 @@ function resolveTagVariables(
let resolvedCode = code
const undefinedLiteral = language === 'python' ? 'None' : 'undefined'

// Inject block outputs as direct JavaScript variables
// This allows `blockName.field` syntax in conditions without angle brackets
injectBlockVariables(blockData, blockNameMapping, contextVariables)

const tagPattern = new RegExp(
`${REFERENCE.START}([a-zA-Z_](?:[a-zA-Z0-9_${REFERENCE.PATH_DELIMITER}]*[a-zA-Z0-9_])?)${REFERENCE.END}`,
'g'
Expand Down