Skip to content

Conversation

@Uyadav207
Copy link
Contributor

@Uyadav207 Uyadav207 commented Mar 14, 2021

What kind of change does this PR introduce?

  • Add to 9 prop_explorers with complete prop detailings from RNE CORE .

Did you add tests for your changes?

  • Not required (manually tested)

If relevant, did you update the documentation?

  • Not required

Summary

Fixes #43

Motivation

  • Props explorer are only introduced in some of the components.

props updated

Screenshot from 2021-03-14 12-31-44
Screenshot from 2021-03-15 12-34-27

Does this PR introduce a breaking change?

  • New files are introduced mdx. so chances of conflict or any breaking of the application.

Other information

  • Working on improving styling.

@pranshuchittora, I have done with the discussed changes. Kindly review it.

@netlify
Copy link

netlify bot commented Mar 14, 2021

Deploy preview for rne-playground ready!

Built with commit 212474f

https://deploy-preview-67--rne-playground.netlify.app

@Uyadav207
Copy link
Contributor Author

Uyadav207 commented Mar 14, 2021

Fixes #43

@Uyadav207
Copy link
Contributor Author

Uyadav207 commented Mar 14, 2021

Fixes #43 completely.

What I did?

  • Broken this major addition into small chunks.
  • Made different commits to avoid any breaking conflicts.

@pranshuchittora, A request..... that to avoid merge conflict...the sequence to merge this PR with all other PR of mine is:

@Uyadav207 Uyadav207 changed the title 🚀feat: add to 9 prop_explorers with complete prop detailings from RNE CORE 🚀feat: add to all prop_explorers with complete prop detailing from RNE CORE Mar 14, 2021
@pranshuchittora
Copy link
Member

Pls check #15
It was long-awaited PR.

Kindly, close this if this overlaps with the same

@Uyadav207 Uyadav207 closed this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: Adding prop explorer for AirBnB rating and all other props

3 participants