ensures that padded space is not larger than figure #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I added the built files to commit 6f19390 to enable easy inclusion in plotly.js' |
src/sankey.js
Outdated
| var L = max(nodesByBreadth, function(nodes) { | ||
| return nodes.length; | ||
| }); | ||
| var maxNodePadding = 2/3 * size[1] / (L - 1); |
Collaborator
There was a problem hiding this comment.
I like the 2/3 - looks good. Lets define it up top though by the properties block:
Lines 7 to 11 in 6f19390
not that I think we need to make it a property now, though we may want to do that later. For now I just want it to be easier to find, in case someone's wondering why they get our warning (or why the padding refuses to get bigger)
Author
There was a problem hiding this comment.
Thank you for pointing this out! It should now be resolved in commit 1a79abb!
Collaborator
|
💃 Very nice and clean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix this issue plotly/plotly.js#3140, we override
nodePaddingif it's too large.