fix(FileDisplayResponse): return 404 if not found #57797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

susnux wants to merge 1 commit into master from fix/proper-handling-404

Contributor

susnux commented Jan 26, 2026

Summary

If the linked file is not found (anymore) return proper 404 status code.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)


          fix(FileDisplayResponse): return 404 if not found

9d8d48a

If the linked file is not found (anymore) return proper 404
status code.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

susnux requested a review from a team as a code owner

January 26, 2026 01:02

susnux added bug 3. to review labels

susnux requested review from icewind1991, leftybournes, provokateurin and salmart-dev and removed request for a team

January 26, 2026 01:02

susnux added this to the Nextcloud 34 milestone

provokateurin approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

provokateurin provokateurin approved these changes

icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Labels

3. to review bug