Skip to content

Update SFTP.php #57793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pac0san wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update SFTP.php #57793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/files_external/lib/Lib/Storage/SFTP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ public function __construct(array $parameters) {
$parsedHost = $this->splitHost($parameters['host']);

$this->host = $parsedHost[0];
$this->port = $parsedHost[1];
if (isset($parameters['port'])) {
$this->port = $parameters['port'];
}
Comment on lines -73 to +75
Copy link
Member

@provokateurin provokateurin Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. $parsedHost[1] already has the port from the parameters, so it is already working.

Copy link
Author

@pac0san pac0san Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried? I did.

I reviewed the related code and found that $parsedHost[1] didn’t include the alternative SFTP port; it always ended up using port 22.

I have an sshd server listening on TCP port 222, and the logs showed repeated SFTP login failures because it was trying port 22 instead of 222 — until I applied this patch.

It works correctly now.

Regards: Paco.-


if (!isset($parameters['user'])) {
throw new \UnexpectedValueException('no authentication parameters specified');
Expand Down