Skip to content

refactor(shareByMail): Strict types and code simplification #57785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
come-nc merged 1 commit into from
Jan 27, 2026
Merged

refactor(shareByMail): Strict types and code simplification #57785

come-nc merged 1 commit into from
Jan 27, 2026
+90 −170

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Jan 24, 2026

Checklist

@solracsf solracsf changed the title refactor(sahreByMail): Strict types and code simplification refactor(shareByMail): Strict types and code simplification Jan 24, 2026
@solracsf solracsf added feature: emails ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 24, 2026
@solracsf solracsf added this to the Nextcloud 34 milestone Jan 24, 2026
@solracsf
refactor(shareByMail): Strict types and code simplification
ce9119a 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added the 3. to review Waiting for reviews label Jan 24, 2026
@solracsf solracsf marked this pull request as ready for review January 24, 2026 18:40
@solracsf solracsf requested a review from a team as a code owner January 24, 2026 18:40
@solracsf solracsf requested review from ArtificialOwl, come-nc, icewind1991 and provokateurin and removed request for a team January 24, 2026 18:40
CarlSchwan
CarlSchwan approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@come-nc come-nc merged commit 5bc3ae7 into master Jan 27, 2026
176 checks passed
@come-nc come-nc deleted the reactorShareByMail branch January 27, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: emails ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

4 participants

@solracsf @CarlSchwan @come-nc