Code completion for target with generic builder not working

[thunderhook]

First of all, thank your awesome work!

We use some generated classes as target and sadly the code completion won't work.
I have reproduced and trimmed the generated class, so that the problem can be reproduced.
Note the comments inside the class to get the completion working (to find the culprit).

Thanks in advance. Please tell me when I can provide further help.

import org.mapstruct.Mapper;
import org.mapstruct.Mapping;

@Mapper
public abstract class DemoMapper {

	// code completion for target broken - see comments down below to see the culprit
	@Mapping(target = "status", source = "input")
	public abstract DemoTypeWithBuilder map(String input);

	public static class DemoTypeWithBuilder {

		protected String status;
		protected int data;

		public String getStatus() {return status;}

		public void setStatus(String value) {this.status = value;}

		public int getData() {return data;}

		public void setData(int value) {this.data = value;}

		/**
		 * when commenting out this static builder method, then auto complete lists values as expected:
		 * "status", "data"
		 */
		public static DemoTypeWithBuilder.Builder<Void> builder() {
			return new DemoTypeWithBuilder.Builder<Void>(null, null, false);
		}

		public static class Builder<_B> {

			protected final _B _parentBuilder;
			protected final DemoTypeWithBuilder _storedValue;
			private String status;
			private int data;

			public Builder(final _B _parentBuilder, final DemoTypeWithBuilder _other, final boolean _copy) {
				this._parentBuilder = _parentBuilder;
				if (_other != null) {
					if (_copy) {
						_storedValue = null;
						this.status = _other.status;
						this.data = _other.data;
					} else {
						_storedValue = _other;
					}
				} else {
					_storedValue = null;
				}
			}

			/**
			 * when commenting out this constructor, then auto-complete lists:
			 * "_copy", "_other", "_parentBuilder"
			 */
			public Builder(final _B _parentBuilder, final DemoTypeWithBuilder _other, final boolean _copy, final PropertyTree _propertyTree, final
			PropertyTreeUse _propertyTreeUse) {
				this._parentBuilder = _parentBuilder;
				if (_other != null) {
					if (_copy) {
						_storedValue = null;
						final PropertyTree statusPropertyTree = ((_propertyTree == null) ? null : _propertyTree.get("status"));
						if (((_propertyTreeUse == PropertyTreeUse.INCLUDE) ? (statusPropertyTree != null) : ((statusPropertyTree == null) || (!statusPropertyTree.isLeaf())))) {
							this.status = _other.status;
						}
						final PropertyTree dataPropertyTree = ((_propertyTree == null) ? null : _propertyTree.get("data"));
						if (((_propertyTreeUse == PropertyTreeUse.INCLUDE) ? (dataPropertyTree != null) : ((dataPropertyTree == null) || (!dataPropertyTree.isLeaf())))) {
							this.data = _other.data;
						}
					} else {
						_storedValue = _other;
					}
				} else {
					_storedValue = null;
				}
			}

			protected <_P extends DemoTypeWithBuilder> _P init(final _P _product) {
				_product.status = this.status;
				_product.data = this.data;
				return _product;
			}

			public DemoTypeWithBuilder.Builder<_B> withStatus(final String status) {
				this.status = status;
				return this;
			}

			public DemoTypeWithBuilder.Builder<_B> withData(final int data) {
				this.data = data;
				return this;
			}

			public DemoTypeWithBuilder build() {
				if (_storedValue == null) {
					return this.init(new DemoTypeWithBuilder());
				} else {
					return _storedValue;
				}
			}
		}
	}

	// mock for com.kscs.util.jaxb.PropertyTreeUse
	public static class PropertyTreeUse {

	}

	// mock for com.kscs.util.jaxb.PropertyTree
	public static class PropertyTree {

	}
}

[filiphr]

Thanks for the detailed reproducal @thunderhook. It helped locate the problem. There were 2 problems actually:

• We incorrectly use constructor parameters from the Builder class
• Generic builder methods were not properly recognized

---

Just FYI, with the current builder the MapStruct processor will treat withStatus as a single property. Therefore, @Mapping(target = "status", source = "input") is not valid and it needs to be @Mapping(target = "withStatus", source = "input")

That is unless you have a custom AccessorNamingStrategy.

[thunderhook]

Thank your for the fix and the hint about the AccessorNamingStrategy. 👍