feat: add support for github cloud data residency #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <adam.setch@outlook.com>
github-actions
bot
added
the
enhancement
setchy
requested review from
Copilot
and removed request for
afonsojramos and
bmulholland
There was a problem hiding this comment.
Pull request overview
This PR adds support for GitHub Enterprise Cloud with Data Residency, which uses *.ghe.com domains according to GitHub's documentation. The implementation extends the existing platform detection and API configuration logic to handle this new platform type alongside GitHub Cloud and GitHub Enterprise Server.
Changes:
- Added 'GitHub Enterprise Cloud with Data Residency' as a new
PlatformType - Implemented hostname detection for
.ghe.comdomains - Updated API and authentication URL construction to use
api.subdomain.ghe.compattern - Added ShieldCheckIcon for the new platform type
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/utils/auth/types.ts | Extended PlatformType union type to include 'GitHub Enterprise Cloud with Data Residency' |
| src/renderer/constants.ts | Added GITHUB_ENTERPRISE_CLOUD_DATA_RESIDENCY_HOSTNAME constant for 'ghe.com' |
| src/renderer/utils/helpers.ts | Updated getPlatformFromHostname to detect .ghe.com domains and added isCloudDataResidencyHost helper |
| src/renderer/utils/helpers.test.ts | Added comprehensive tests for Data Residency hostname detection |
| src/renderer/utils/api/utils.ts | Updated getGitHubAPIBaseUrl to construct api.subdomain.ghe.com URLs for Data Residency |
| src/renderer/utils/api/utils.test.ts | Added tests for Data Residency REST and GraphQL API URL generation |
| src/renderer/utils/auth/utils.ts | Updated getGitHubAuthBaseUrl to support Data Residency, replaced isEnterpriseServerHost check with getPlatformFromHostname |
| src/renderer/utils/icons.ts | Added ShieldCheckIcon for Data Residency platform |
| src/renderer/utils/icons.test.ts | Added snapshot test for Data Residency platform icon |
| src/renderer/utils/snapshots/icons.test.ts.snap | Generated snapshot for ShieldCheckIcon |
| src/renderer/mocks/account-mocks.ts | Added mock account for Data Residency testing |
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2560