-
Notifications
You must be signed in to change notification settings - Fork 65.7k
Fix reusable template expansion in Dependabot Actions examples #42195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix reusable template expansion in Dependabot Actions examples #42195
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the {% data reusables.actions.actions-not-certified-by-github-comment %} reusable template was not expanding in four YAML code blocks within the Dependabot automation documentation. The template was wrapped in {% raw %}...{% endraw %} tags, which prevented Liquid from processing it.
Key changes:
- Removed
{% raw %}and{% endraw %}wrapper tags from four YAML code blocks to allow proper template expansion - Aligns the code block formatting with other documentation files (e.g.,
publish-docker-images.md) where the same reusable is used successfully
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@heathdutton Thanks for opening a PR to fix this! It took me a minute to understand what was going on, but, yes, you're right that the raw tag is a problem in these cases. It looks like there are some conflicts that need to be resolved - not sure what happened, but I'm guessing some articles got moved around. Do you think you could rebase the PR to resolve that problem? After that I can get it approved. |
3be6cb9 to
5a07481
Compare
|
@Sharra-writes conflicts resolved. |
|
@heathdutton I just found out today that part of the team has started a project to rearrange the code security docs, so I'm going to mark this as "ready to merge" and come back to it after they're done moving things around. Sorry, I didn't realize that project had started already. |
Why:
The
{% data reusables.actions.actions-not-certified-by-github-comment %}template was not being expanded in the Dependabot automation examples because the code blocks were wrapped in{% raw %}...{% endraw %}tags.Closes: #41897
What's being changed:
Removed the
{% raw %}and{% endraw %}wrappers from the four YAML code blocks so that the reusable template expands correctly, matching the pattern used in other docs (e.g., publish-docker-images.md).Check off the following: