Add flag Find all Markdown files, Ignore ts/te tags, Automatically at the end/head of the file. #115
Conversation
--auto Ignore ts/te tags, Automatically at the end/head of the file --head The TOC is generated in the header of the file, requires --auto
ekalinin
left a comment
ekalinin
left a comment
There was a problem hiding this comment.
Thanks for the patch!
Could you, please, check my comments.
And one more thing: could you add some tests for a new functionality?
| # | ||
|
|
||
| gh_toc_version="0.7.0" | ||
| gh_toc_version="0.8.0" |
There was a problem hiding this comment.
Let's leave current value for now
| echo "yes";; | ||
| *) | ||
| echo "no";; | ||
| https* | http*) |
There was a problem hiding this comment.
Could you, please, revert these changes?
Thus, total diff will be much smaller and easier to review.
Thanks.
| exit 1 | ||
| fi | ||
| local toc=`echo "$rawhtml" | gh_toc_grab "$gh_src_copy"` | ||
| local toc=$(echo "$rawhtml" | gh_toc_grab "$gh_src_copy") |
There was a problem hiding this comment.
What's the point to change ` to $(?
Without this change total diff will be much simpler.
There was a problem hiding this comment.
| # Find all Markdown files for non-hidden folders | ||
| # | ||
| all_md_filename="" | ||
| gh_all_md_filename() { |
There was a problem hiding this comment.
Using globals is a bad pattern.
Could you, please, improve gh_all_md_filename and just return the result from the function (without using global variable all_md_filename).
| local ts="<\!--ts-->" | ||
| local te="<\!--te-->" | ||
| local dt=`date +'%F_%H%M%S'` | ||
| local dt=$(date +'%F_%H%M%S') |
There was a problem hiding this comment.
And again :) what's the point to change ` to $(?
There was a problem hiding this comment.
| local ext=".orig.${dt}" | ||
| local toc_path="${gh_src}.toc.${dt}" | ||
| local toc_footer="<!-- Added by: `whoami`, at: `date` -->" | ||
| local toc_footer="<!-- Added by: $(whoami), at: $(date) -->" |
There was a problem hiding this comment.
And again :) what's the point to change ` to $(?
There was a problem hiding this comment.
| # clear old TOC | ||
| sed -i${ext} "/${ts}/,/${te}/{//!d;}" "$gh_src" | ||
| # create toc file | ||
| echo "${toc}" > "${toc_path}" |
There was a problem hiding this comment.
Could you please, revert back the origin formatting?
Without this change total diff will be much simpler.
| echo "os: `lsb_release -d | cut -f 2`" | ||
| echo "kernel: `cat /proc/version`" | ||
| echo "shell: `$SHELL --version`" | ||
| echo "os: $(lsb_release -d | cut -f 2)" |
There was a problem hiding this comment.
And again :) what's the point to change ` to $(?
There was a problem hiding this comment.
|
I could revert to these changes, but this project seems to need a shell style checker |
2 participants
--all Find all Markdown files for non-hidden folders
--auto Ignore ts/te tags, Automatically at the end/head of the file
--head The TOC is generated in the header of the file, requires --auto