Skip to content

fix winning rate output bug of smac #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangshiyu13 merged 1 commit into from
Oct 18, 2023
Merged

fix winning rate output bug of smac #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/smac/custom_vecinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ def statistics(self, buffer: Any) -> Dict[str, Any]:
assert (
"game_state" in singe_env_info["final_info"].keys()
), "game_state must be in info"
assert singe_env_info["final_info"]["game_state"] in [
"win",
"lose",
], "game_state in the final_info must be win or lose"
# assert singe_env_info["final_info"]["game_state"] in [
# "win",
# "lose",
# ], "game_state in the final_info must be win or lose"
self.win_history.append(
singe_env_info["final_info"]["game_state"] == "win"
)
Expand Down
3 changes: 2 additions & 1 deletion examples/smac/train_ppo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ def train():
# create environment
env_num = 8
env = make(
"2s_vs_1sc",
"3m",
# "2s_vs_1sc",
env_num=env_num,
asynchronous=True,
cfg=cfg,
Expand Down
14 changes: 7 additions & 7 deletions examples/smacv2/custom_vecinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,21 @@ def __init__(self, *args, **kwargs):
def statistics(self, buffer: Any) -> Dict[str, Any]:
info_dict = super().statistics(buffer)

"""for step_info in self.infos:
for step_info in self.infos:
for singe_env_info in step_info:
assert isinstance(singe_env_info, dict), "singe_env_info must be dict"

if "final_info" in singe_env_info.keys():
assert (
"game_state" in singe_env_info["final_info"].keys()
), "game_state must be in info"
assert singe_env_info["final_info"]["game_state"] in [
"win",
"lose",
], "game_state in the final_info must be win or lose"
), "win_state must be in info"
# assert singe_env_info["final_info"]["game_state"] in [
# "win",
# "lose",
# ], "win_state in the final_info must be win or lose"
self.win_history.append(
singe_env_info["final_info"]["game_state"] == "win"
)"""
)

if len(self.win_history) > 0:
info_dict["win_rate"] = np.mean(self.win_history)
Expand Down