feat(secretmanager): Adding etag samples

[khilan-crest]

Adding etag samples

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test (see Testing)
• Lint pass: npm run lint (see Style)
• Required CI tests pass (see CI testing)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

[snippet-bot]

Here is the summary of changes.

You are about to add 35 region tags.

• secret-manager/createSecretWithCmek.js:18, tag secretmanager_create_secret_with_cmek
• secret-manager/createSecretWithExpiration.js:18, tag secretmanager_create_secret_with_expiration
• secret-manager/createSecretWithRotation.js:18, tag secretmanager_create_secret_with_rotation
• secret-manager/createSecretWithTopic.js:18, tag secretmanager_create_secret_with_topic
• secret-manager/createSecretWithUserManagedReplicationPolicy.js:18, tag secretmanager_create_ummr_secret
• secret-manager/deleteSecretExpiration.js:18, tag secretmanager_delete_secret_expiration
• secret-manager/deleteSecretRotation.js:18, tag secretmanager_delete_secret_rotation
• secret-manager/deleteSecretWithEtag.js:18, tag secretmanager_delete_secret_with_etag
• secret-manager/destroySecretVersionWithEtag.js:18, tag secretmanager_destroy_secret_version
• secret-manager/detachTagBinding.js:18, tag secretmanager_detach_tag_binding
• secret-manager/disableSecretVersionWithEtag.js:18, tag secretmanager_disable_secret_version_with_etag
• secret-manager/enableSecretVersionWithEtag.js:18, tag secretmanager_enable_secret_version_with_etag
• secret-manager/listSecretVersionsWithFilter.js:18, tag secretmanager_list_secret_versions_with_filter
• secret-manager/listSecretsWithFilter.js:18, tag secretmanager_list_secrets_with_filter
• secret-manager/listTagBindings.js:18, tag secretmanager_list_tag_bindings
• secret-manager/regional_samples/createRegionalSecretWithCmek.js:18, tag secretmanager_create_secret_with_cmek
• secret-manager/regional_samples/createRegionalSecretWithExpiration.js:18, tag secretmanager_create_regional_secret_with_expire_time
• secret-manager/regional_samples/createRegionalSecretWithRotation.js:18, tag secretmanager_create_regional_secret_with_rotation
• secret-manager/regional_samples/createRegionalSecretWithTopic.js:18, tag secretmanager_create_regional_secret_with_topic
• secret-manager/regional_samples/deleteRegionalSecretExpiration.js:18, tag secretmanager_delete_regional_secret_expiration
• secret-manager/regional_samples/deleteRegionalSecretRotation.js:18, tag secretmanager_delete_regional_secret_rotation
• secret-manager/regional_samples/deleteRegionalSecretWithEtag.js:18, tag secretmanager_v1_delete_regional_secret_with_etag
• secret-manager/regional_samples/destroyRegionalSecretVersionWithEtag.js:18, tag secretmanager_destroy_regional_secret_version
• secret-manager/regional_samples/detachRegionalTag.js:18, tag secretmanager_detach_regional_tag
• secret-manager/regional_samples/disableRegionalSecretVersionWithEtag.js:18, tag secretmanager_disable_regional_secret_version_with_etag
• secret-manager/regional_samples/enableRegionalSecretVersionWithEtag.js:18, tag secretmanager_enable_regional_secret_version_with_etag
• secret-manager/regional_samples/listRegionalSecretVersionsWithFilter.js:18, tag secretmanager_list_regional_secret_versions_with_filter
• secret-manager/regional_samples/listRegionalSecretsWithFilter.js:18, tag secretmanager_list_regional_secrets_with_filter
• secret-manager/regional_samples/listRegionalTagBindings.js:18, tag secretmanager_list_regional_secret_tag_bindings
• secret-manager/regional_samples/updateRegionalSecretExpiration.js:18, tag secretmanager_update_regional_secret_expiration
• secret-manager/regional_samples/updateRegionalSecretRotation.js:18, tag secretmanager_update_regional_secret_rotation_period
• secret-manager/regional_samples/updateRegionalSecretWithEtag.js:18, tag secretmanager_v1_update_regional_secret_with_etag
• secret-manager/updateSecretExpiration.js:18, tag secretmanager_update_secret_expiration
• secret-manager/updateSecretRotation.js:18, tag secretmanager_update_secret_rotation
• secret-manager/updateSecretWithEtag.js:18, tag secretmanager_update_secret_with_etag

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[gemini-code-assist]

Summary of Changes

Hello @khilan-crest, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Node.js sample collection for Google Cloud Secret Manager. It introduces a wide array of new functionalities, including advanced secret creation options, lifecycle management (expiration, rotation), concurrency control using ETags, and integration with other Google Cloud services like Pub/Sub and KMS. Furthermore, it provides a complete suite of regional Secret Manager samples, ensuring comprehensive coverage for various deployment scenarios.

Highlights

• New Secret Management Samples: A comprehensive set of new Node.js samples for Google Cloud Secret Manager has been added, demonstrating various advanced functionalities.
• ETag Support: Several new samples showcase the use of ETags for optimistic concurrency control when performing operations like deleting secrets, destroying secret versions, and enabling/disabling secret versions.
• Secret Configuration Options: New samples cover creating secrets with advanced configurations, including Customer-Managed Encryption Keys (CMEK), setting expiration times, defining rotation policies, and integrating with Pub/Sub topics for notifications.
• Replication Policies: A new sample illustrates how to create secrets with user-managed replication policies, allowing secrets to be replicated across specified locations.
• Filtering and Listing: Samples for listing secrets and secret versions with specific filters, as well as listing and detaching tag bindings, have been introduced to enhance secret discovery and management.
• Regional Secret Operations: A dedicated suite of samples for regional Secret Manager operations has been added, mirroring many of the global secret management functionalities to support regional deployments.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces several new samples for Secret Manager, covering features like CMEK, expiration, rotation, user-managed replication, tag bindings, and etag operations for both global and regional secrets and versions. The accompanying test file has been updated to include comprehensive tests for these new functionalities, which is great. However, there are a few minor issues related to asynchronous function calls and type handling that should be addressed.