[ENG-9198] Do not show page not found for preprint pending moderation #11567
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors/Logged-out users using /pending-moderation redirection on access
…moderation and is not yet publicly available.' logic
ihorsokhanexoft
suggested changes
Jan 30, 2026
| # May raise a permission denied | ||
| if check_object_permissions: | ||
| self.check_object_permissions(self.request, preprint) | ||
|
|
Contributor
There was a problem hiding this comment.
I believe it's better to leave it where it was in order to not break current behavior
Contributor
Author
There was a problem hiding this comment.
it is needed to implement the following workflow and behaviour described in the ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
There is no unified access-control handling for preprints that are pending moderation. The system does not consistently intercept direct access attempts and route non-authorized users to a clear, informative state explaining that the preprint is under moderation.
Introduce a generic static “Preprint Pending Moderation” page that is shown when a preprint is in a pending moderation state and belongs to a provider that requires pre-moderation.
Allowed access:
Contributors on the preprint (all roles: read, write, admin)
Moderators for the specific preprint provider
Restricted access:
Logged-in users who are not contributors
Logged-in users who are not moderators for that provider
Logged-out users
Any general user accessing the preprint via direct URL
Changes
if preprint is pending moderation show it for not contributors/moderators/Logged-out users using /pending-moderation redirection on access (ticket related front end updates CenterForOpenScience/angular-osf#835)
96a5-15e4-48c7-8a79-17ff261adc06.mp4
Side Effects
QE Notes
CE Notes
Documentation