feat!: Use query option pattern and support useSuspense #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajzik
changed the title
Owner
|
This is actually very cool, let’s try to make this merged! |
added 5 commits
January 21, 2025 14:10
…ery components to use query function; Add suspense query to the generation; Update context
rajzik
force-pushed
the
breaking-change-add-multiple-changes-to-react-query
branch
from
4925fa7 to
26ede5b
Compare
added 2 commits
January 21, 2025 14:30
Contributor
Author
|
@fabien0102 rebased and ready for review |
fabien0102
reviewed
Jan 30, 2025
| @@ -22,10 +22,6 @@ export const getContext = (prefix: string, componentsFile: string) => | |||
| */ | |||
| enabled?: boolean; | |||
Owner
There was a problem hiding this comment.
We need to adjust the type of the enabled param, after some manual integration test with the github example I got this type error:
Note to myself: some love is needed for the integration test, it’s a bit painful to setup right now
fabien0102
changed the title
fabien0102
approved these changes
Jan 30, 2025
Owner
fabien0102
left a comment
fabien0102
left a comment
There was a problem hiding this comment.
Looks good! I did update the context template to fit the new types requirement. Let’s ship this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to query option pattern.
This is a breaking change:
{namespace}Contextneeds to be updated!react-query@5is required (useSuspense support)Ref
https://tkdodo.eu/blog/the-query-options-api