Skip to content

Improve memory accounting for ArrowBytesViewMap #20077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vigneshsiva11 wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −1
Open

Improve memory accounting for ArrowBytesViewMap #20077

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52ee782
Improve memory accounting for ArrowBytesViewMap
vigneshsiva11 Jan 30, 2026
e572a5f
Update datafusion/physical-expr-common/src/binary_view_map.rs
vigneshsiva11 Jan 30, 2026
7ed458e
Use allocated_size directly for null buffer accounting
vigneshsiva11 Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/physical-expr-common/src/binary_view_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ where
let views_size = self.views.len() * size_of::<u128>();
let in_progress_size = self.in_progress.capacity();
let completed_size: usize = self.completed.iter().map(|b| b.len()).sum();
let nulls_size = self.nulls.len() / 8;
let nulls_size = self.nulls.allocated_size();

self.map_size
+ views_size
Expand Down